Allow storing extra data on objects before persisting #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Json configs used by EF
…pplied to objects, not only when using projected tables
…ferent workaround
…to enable EF Service provider caching as that makes our performance degrade enough to fail the tests
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: c5bbd2b | Previous: 1f46e1b | Ratio |
|---|---|---|---|
SIL.Harmony.Tests.DataModelPerformanceBenchmarks.AddSingleChangePerformance(StartingSnapshots: 0) |
13894032.7 ns (± 349161.7281754338) |
3456289.8444444444 ns (± 214593.83164569302) |
4.02 |
SIL.Harmony.Tests.DataModelPerformanceBenchmarks.AddSingleChangeWithManySnapshots(StartingSnapshots: 0) |
4150403.2 ns (± 327431.08142250497) |
3699745.5425531915 ns (± 494121.6697817738) |
1.12 |
SIL.Harmony.Tests.DataModelPerformanceBenchmarks.AddSingleChangePerformance(StartingSnapshots: 1000) |
14070519.2 ns (± 337502.7173601882) |
3246536.9411764704 ns (± 91308.33685423991) |
4.33 |
SIL.Harmony.Tests.DataModelPerformanceBenchmarks.AddSingleChangeWithManySnapshots(StartingSnapshots: 1000) |
5144490.4 ns (± 474222.7315656642) |
3784068.7966101696 ns (± 165621.81273474856) |
1.36 |
SIL.Harmony.Tests.DataModelPerformanceBenchmarks.AddSingleChangePerformance(StartingSnapshots: 10000) |
13306648.4 ns (± 466980.7254119453) |
2797261.086956522 ns (± 106666.84588293821) |
4.76 |
SIL.Harmony.Tests.DataModelPerformanceBenchmarks.AddSingleChangeWithManySnapshots(StartingSnapshots: 10000) |
13231247.4 ns (± 2210424.871172518) |
10299036.5 ns (± 152038.38387368855) |
1.28 |
This comment was automatically generated by workflow using github-action-benchmark.
myieye
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this case we wanted to store commt Ids on our objects